From 8138212a27c4d572dc6f797626e6b0f92d5995bb Mon Sep 17 00:00:00 2001 From: Daniel Rudolf Date: Thu, 3 Aug 2017 22:17:48 +0200 Subject: [PATCH] Pico::evaluateRequestUrl(): Improve REQUEST_URI handling Don't 404 "/index.php" requests --- lib/Pico.php | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/Pico.php b/lib/Pico.php index 327f7ac..f936de1 100644 --- a/lib/Pico.php +++ b/lib/Pico.php @@ -972,8 +972,12 @@ class Pico $requestUri = isset($_SERVER['REQUEST_URI']) ? $_SERVER['REQUEST_URI'] : ''; if ($requestUri && (substr($requestUri, 0, $basePathLength) === $basePath)) { $requestUri = substr($requestUri, $basePathLength); - $requestUri = strstr($requestUri, '?', true) ?: $requestUri; - $this->requestUrl = rtrim(rawurldecode($requestUri), '/'); + if ($requestUri && (($queryStringPos = strpos($requestUri, '?')) !== false)) { + $requestUri = substr($requestUri, 0, $queryStringPos); + } + if ($requestUri && ($requestUri !== basename($_SERVER['SCRIPT_NAME']))) { + $this->requestUrl = rtrim(rawurldecode($requestUri), '/'); + } } } }